Re: [Qemu-devel] [RFC PATCH v8 21/21] replay: recording of the user input

[Pavel Dovgaluk]

> From: Paolo Bonzini [mailto:address@hidden On Behalf Of Paolo Bonzini
> On 22/01/2015 09:53, Pavel Dovgalyuk wrote:
> > +void replay_input_event(QemuConsole *src, InputEvent *evt)
> > +{
> > +    if (replay_mode == REPLAY_MODE_PLAY) {
> > +        /* Nothing */
> > +    } else if (replay_mode == REPLAY_MODE_RECORD) {
> > +        replay_add_input_event(evt);
> 
> Does replay_add_input_event ultimately call qemu_input_event_send_impl?

No, it just adds event to the queue.

> > +    } else {
> > +        qemu_input_event_send_impl(src, evt);
> > +    }
> > +}
> > +
> 
> Perhaps make this and replay_input_sync_event return a bool and in the
> caller do:
> 
>     if (replay_input_event(src, evt)) {
>         qemu_input_event_send_impl(src, evt):
>     }

No, we can't. qemu_input_event_send_impl is called when the queue is saved to 
the log.

Pavel Dovgalyuk