[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] virtio: remove QEMU definition of VIRTIO_TR
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/2] virtio: remove QEMU definition of VIRTIO_TRANSPORT_F_START/_END |
|
Date: |
Thu, 12 Feb 2015 14:41:15 +0000 |
On 12 February 2015 at 13:08, Jens Freimann <address@hidden> wrote:
> We have defines for VIRTIO_TRANSPORT_F_START/_END in two places.
> In include/hw/virtio/virtio.h and in linux-headers/linux/virtio_config.h
>
> Since we already get virtio_config.h via update-linux-headers.sh,
> there's no need to have duplicate defines in QEMU headers files.
>
> Let's remove this define from include/hw/virtio/virtio.h
Isn't this going to break compilation on non-linux hosts?
They don't get linux-headers/ on their include path, so
our virtio.h is their only source for this define...
-- PMM