[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v8 21/21] replay: recording of the user inpu
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [RFC PATCH v8 21/21] replay: recording of the user input |
|
Date: |
Thu, 12 Feb 2015 15:41:27 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 12/02/2015 09:08, Pavel Dovgaluk wrote:
>> >
>> > This is wrong. You have different lifetimes for different modes. Please
>> > make a copy of the event in the implementation of record mode.
> What is the correct way for cloning the QAPI type?
> I should invent the cloning visitor or just create a switch for correct
> cloning of the InputEvent union?
You can use the existing visitors to clone objects, see
qapi_copy_SocketAddress in qemu-char.c.
Paolo