Re: [Qemu-devel] [PATCH v2 2/3] numa: Reject configuration if CPU appears on multiple nodes

[Igor Mammedov]

On Thu, 12 Feb 2015 13:24:26 -0200
Eduardo Habkost <address@hidden> wrote:

> On Thu, Feb 12, 2015 at 04:01:49PM +0100, Igor Mammedov wrote:
> > On Mon,  9 Feb 2015 17:53:15 -0200
> > Eduardo Habkost <address@hidden> wrote:
> > 
> > > Each CPU can appear in only one NUMA node on the NUMA config. Reject
> > > configuration if a CPU appears in multiple nodes.
> > > 
> > > Signed-off-by: Eduardo Habkost <address@hidden>
> > > ---
> > >  numa.c | 27 +++++++++++++++++++++++++++
> > >  1 file changed, 27 insertions(+)
> > > 
> > > diff --git a/numa.c b/numa.c
> > > index f768434..f004a74 100644
> > > --- a/numa.c
> > > +++ b/numa.c
> > > @@ -167,6 +167,31 @@ error:
> > >      return -1;
> > >  }
> > >  
> > > +static void validate_numa_cpus(void)
> > > +{
> > > +    int i, cpu;
> > > +    DECLARE_BITMAP(present_cpus, MAX_CPUMASK_BITS);
> > naming is a bit confusing, it's not really present CPUs but
> > more like possible_cpus
> 
> I meant "present in the NUMA configuration". "Possible" wouldn't
> describe it IMO, as it is just tracking the CPUs seen in the config. I
> will rename it to "seen_cpus" in the next version.
or maybe numa_cpus