[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/6] migration: differentiate between pages and
From: |
Li, Liang Z |
Subject: |
Re: [Qemu-devel] [PATCH 0/6] migration: differentiate between pages and bytes |
Date: |
Fri, 13 Feb 2015 02:28:06 +0000 |
> (Li special edition)
>
> Current migration code returns number of bytes transferred and from there
> we decide if we.have sent something or not. Problem, we need two results:
> number of pages written, and number of bytes written (depending on
> compression, zero pages, etc, it is not possible to derive one value from the
> other).
>
> So, I changed all relevant function to return the number of written pages,
> and then pass as uint64_t *bytes_transferred to update the written bytes.
>
> On current code, makes things a bit easier to understand, but is not strictely
> necesary. But for the compression patches from Li, it makes a big difference,
> we can return that we have written a page, even if we have just started the
> write, but having writtten in reality zero bytes.
>
> Once there, I add doxygen documentation to all function that I touched (yes,
> I was long due).
>
> save_block_hdr really saved headers for pages, not blocks. Rename it, and
> simplify the interface.
>
> Li, does this make your life easier? I hope so. Should make really easy to
> remove the one_bytes_sent "hack", and allow my other suggestions.
It's great! the 'one_byte_sent' always make me feel uncomfortable. Thanks,
Juan.
> Comments?
The Chinese New Year coming, I am going to take leaves for about 2 weeks.
I am not sure if I can access Internet during the vacation, so maybe I can't
give reply
for a long time. But I will review your patches and change mine according to
your changes
and suggestions.
Happy Chinese New Year! Now, I'm going to catch the train ...
Liang
- [Qemu-devel] [PATCH 2/6] ram_find_and_save_block: change calling convention, (continued)
- [Qemu-devel] [PATCH 2/6] ram_find_and_save_block: change calling convention, Juan Quintela, 2015/02/12
- [Qemu-devel] [PATCH 5/6] save_block_hdr: we can recalculate the cont parameter here, Juan Quintela, 2015/02/12
- [Qemu-devel] [PATCH 6/6] rename save_block_hdr to save_page_header, Juan Quintela, 2015/02/12
- [Qemu-devel] [PATCH 3/6] ram_save_page: change calling covention, Juan Quintela, 2015/02/12
- [Qemu-devel] [PATCH 4/6] save_xbzrle_page: change calling convention, Juan Quintela, 2015/02/12
- Re: [Qemu-devel] [PATCH 0/6] migration: differentiate between pages and bytes,
Li, Liang Z <=
- Re: [Qemu-devel] [PATCH 0/6] migration: differentiate between pages and bytes, Dr. David Alan Gilbert, 2015/02/17
- Re: [Qemu-devel] [PATCH 0/6] migration: differentiate between pages and bytes, Alex Bennée, 2015/02/26