[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] bitops.h: sextract64() return type should be in
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH] bitops.h: sextract64() return type should be int64_t, not uint64_t |
|
Date: |
Thu, 12 Feb 2015 22:21:23 -0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 02/06/2015 06:02 AM, Peter Maydell wrote:
> The documentation for sextract64() claims that the return type is
> an int64_t, but the code itself disagrees. Fix the return type to
> conform to the documentation and to bring it into line with
> sextract32(), which returns int32_t.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> I quickly eyeballed all the callers and I don't think any of them
> were relying on the unsignedness of the return type.
> ---
> include/qemu/bitops.h | 2 +-
Reviewed-by: Richard Henderson <address@hidden>
Via trivial?
r~