[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] memory: Fix double unref of flatview
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH] memory: Fix double unref of flatview |
|
Date: |
Fri, 13 Feb 2015 10:29:36 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 13/02/2015 04:29, Matthew Rosato wrote:
> FYI, then this probably also affects the places you hit in d8d9581460
> "memory: convert memory_region_destroy to object_unparent", as that's
> what I modeled this approach on -- but I haven't tested any of them.
Luckily not, because only "real" regions (not aliases and containers)
end up in a FlatView. So you can do object_unparent on aliases and
containers. It's ugly and should be avoided, but not buggy.
There's only three cases (VFIO, for which patches have been posted and
reviewed already, plus other two in PCI) that have to be modified.
Paolo