qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 03/16] block: Add Error parameter to bdrv_fin


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH v4 03/16] block: Add Error parameter to bdrv_find_protocol()
Date: Fri, 13 Feb 2015 12:58:50 +0000
User-agent: Mutt/1.5.23 (2014-03-12)

On Thu, Feb 05, 2015 at 01:58:12PM -0500, Max Reitz wrote:
> The argument given to bdrv_find_protocol() is just a file name, which
> makes it difficult for the caller to reconstruct what protocol
> bdrv_find_protocol() was hoping to find. This patch adds an Error
> parameter to that function to solve this issue.
> 
> Suggested-by: Eric Blake <address@hidden>
> Signed-off-by: Max Reitz <address@hidden>
> ---
>  block.c                    | 14 +++++++-------
>  block/sheepdog.c           |  2 +-
>  include/block/block.h      |  3 ++-
>  qemu-img.c                 | 11 +++++++----
>  tests/qemu-iotests/051.out |  4 ++--
>  5 files changed, 19 insertions(+), 15 deletions(-)

Reviewed-by: Stefan Hajnoczi <address@hidden>

Attachment: pgphiBZmCLjHl.pgp
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]