[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] virtio-blk: Remove the stale FIXME comment
From: |
Fam Zheng |
Subject: |
[Qemu-devel] [PATCH] virtio-blk: Remove the stale FIXME comment |
Date: |
Mon, 16 Feb 2015 12:09:40 +0800 |
By default, we have ioeventfd enabled, so the IO request processing is
in IO thread; in the vcpu thread, guest mode is returned to as quickly
as possible, and completion is delivered via irqfd. Therefore this
comment from the initial implementation is barely relevant.
Signed-off-by: Fam Zheng <address@hidden>
---
hw/block/virtio-blk.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
index 1a8a176..29c8d33 100644
--- a/hw/block/virtio-blk.c
+++ b/hw/block/virtio-blk.c
@@ -591,12 +591,6 @@ static void virtio_blk_handle_output(VirtIODevice *vdev,
VirtQueue *vq)
if (mrb.num_reqs) {
virtio_blk_submit_multireq(s->blk, &mrb);
}
-
- /*
- * FIXME: Want to check for completions before returning to guest mode,
- * so cached reads and writes are reported as quickly as possible. But
- * that should be done in the generic block layer.
- */
}
static void virtio_blk_dma_restart_bh(void *opaque)
--
1.9.3
- [Qemu-devel] [PATCH] virtio-blk: Remove the stale FIXME comment,
Fam Zheng <=