[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v13 01/17] qapi: Add optional field "name" to bl
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v13 01/17] qapi: Add optional field "name" to block dirty bitmap |
Date: |
Mon, 16 Feb 2015 12:58:39 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 02/13/2015 03:08 PM, John Snow wrote:
> From: Fam Zheng <address@hidden>
>
> This field will be set for user created dirty bitmap. Also pass in an
> error pointer to bdrv_create_dirty_bitmap, so when a name is already
> taken on this BDS, it can report an error message. This is not global
> check, two BDSes can have dirty bitmap with a common name.
>
> Implemented bdrv_find_dirty_bitmap to find a dirty bitmap by name, will
> be used later when other QMP commands want to reference dirty bitmap by
> name.
>
> Add bdrv_dirty_bitmap_make_anon. This unsets the name of dirty bitmap.
>
> Signed-off-by: Fam Zheng <address@hidden>
> Signed-off-by: John Snow <address@hidden>
> Reviewed-by: Max Reitz <address@hidden>
> ---
> block.c | 32 +++++++++++++++++++++++++++++++-
> block/mirror.c | 2 +-
> include/block/block.h | 7 ++++++-
> migration/block.c | 2 +-
> qapi/block-core.json | 4 +++-
> 5 files changed, 42 insertions(+), 5 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v13 00/17] block: incremental backup series, John Snow, 2015/02/13
- [Qemu-devel] [PATCH v13 04/17] block: Introduce bdrv_dirty_bitmap_granularity(), John Snow, 2015/02/13
- [Qemu-devel] [PATCH v13 01/17] qapi: Add optional field "name" to block dirty bitmap, John Snow, 2015/02/13
- Re: [Qemu-devel] [PATCH v13 01/17] qapi: Add optional field "name" to block dirty bitmap,
Eric Blake <=
- [Qemu-devel] [PATCH v13 02/17] qmp: Ensure consistent granularity type, John Snow, 2015/02/13
- [Qemu-devel] [PATCH v13 05/17] hbitmap: add hbitmap_merge, John Snow, 2015/02/13
- [Qemu-devel] [PATCH v13 07/17] block: Add bitmap successors, John Snow, 2015/02/13
- [Qemu-devel] [PATCH v13 09/17] qmp: add block-dirty-bitmap-clear, John Snow, 2015/02/13
- [Qemu-devel] [PATCH v13 06/17] qmp: Add block-dirty-bitmap-enable and block-dirty-bitmap-disable, John Snow, 2015/02/13