[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/13] QemuOpts: Convert qemu_opts_set() to Erro
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 03/13] QemuOpts: Convert qemu_opts_set() to Error, fix its use |
Date: |
Mon, 16 Feb 2015 14:06:36 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 02/16/2015 07:44 AM, Markus Armbruster wrote:
> Return the Error object instead of reporting it with
> qerror_report_err().
>
> Change callers that assume the function can't fail to pass
> &error_abort, so that should the assumption ever break, it'll break
> noisily.
>
> Turns out all callers outside its unit test assume that. We could
> drop the Error ** argument, but that would make the interface less
> regular, so don't.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> include/qemu/option.h | 4 ++--
> net/net.c | 4 ++--
> tests/test-qemu-opts.c | 6 +++---
> util/qemu-option.c | 11 +++++------
> vl.c | 15 ++++++++++-----
> 5 files changed, 22 insertions(+), 18 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 12/13] pc: Use qemu_opt_set() instead of qemu_opts_parse(), (continued)
- [Qemu-devel] [PATCH 12/13] pc: Use qemu_opt_set() instead of qemu_opts_parse(), Markus Armbruster, 2015/02/16
- [Qemu-devel] [PATCH 05/13] block: Suppress unhelpful extra errors in bdrv_img_create(), Markus Armbruster, 2015/02/16
- [Qemu-devel] [PATCH 07/13] QemuOpts: Propagate errors through opts_do_parse(), Markus Armbruster, 2015/02/16
- [Qemu-devel] [PATCH 06/13] QemuOpts: Drop qemu_opt_set(), rename qemu_opt_set_err(), fix use, Markus Armbruster, 2015/02/16
- [Qemu-devel] [PATCH 03/13] QemuOpts: Convert qemu_opts_set() to Error, fix its use, Markus Armbruster, 2015/02/16
- Re: [Qemu-devel] [PATCH 03/13] QemuOpts: Convert qemu_opts_set() to Error, fix its use,
Eric Blake <=
- Re: [Qemu-devel] [PATCH 00/13] QemuOpts: Convert various setters to Error, Markus Armbruster, 2015/02/17