Re: [Qemu-devel] [PATCH v7 07/10] qmp: add rocker device support

[Scott Feldman]

On Mon, Feb 16, 2015 at 5:16 PM, Paolo Bonzini <address@hidden> wrote:
>
>
> On 16/02/2015 22:47, address@hidden wrote:
>> From: Scott Feldman <address@hidden>
>>
>> Add QMP/HMP support for rocker devices.  This is mostly for debugging 
>> purposes
>> to see inside the device's tables and port configurations.  Some examples:
>>
>> (qemu) info rocker sw1
>> name: sw1
>> id: 0x0000013512005452
>> ports: 4
>
> I think CONFIG_ROCKER doesn't work as intended.  It's not exported to C
> files.  I would just merge the other nine patches for 2.3.

Sorry Paolo, I'm was wrong...my #ifdef CONFIG_ROCKER attempt is busted
(thanks David, I just hit same thing).

Can we merge other nine patches for 2.3 and figure out this
CONFIG_ROCKER qmp/hmp next?  I think I'm going to need some help.
Somehow modularizing qmp/hmp so device modules can extend qmp/hmp.  I
had it working before trying to enable it with CONFIG_ROCKER, but it
was intrusive with rocker code in monitor.c/qmp.c/hmp.c, so something
needs to be sorted out.

-scott