Re: [Qemu-devel] [PATCH 04/10] vnc: switch to QemuOpts, allow multiple servers

[Gerd Hoffmann]

On Fr, 2015-02-13 at 19:25 +0100, Markus Armbruster wrote:
> Gerd Hoffmann <address@hidden> writes:
> 
> > This patch switches vnc over to QemuOpts, and it (more or less
> > as side effect) allows multiple vnc server instances.
> >
> > Signed-off-by: Gerd Hoffmann <address@hidden>
> 
> I'm afraid this broke monitor command change vnc.
> 
> Reproducer
> 
>     Terminal 1:
> 
>         $ qemu -nodefaults -S -display vnc=:0 -monitor stdio
>         QEMU 2.2.50 monitor - type 'help' for more information
> 
>     Terminal 2:
> 
>         $ vncviewer :0 
> 
>     Terminal 1:
> 
>         (qemu) change vnc :1
> 
>     Terminal 3:
> 
>         $ vncviewer :1
> 
> Before this patch, vncviewer works both times.  The second one kills the
> first one.
> 
> After this patch, the first one still works, but the second one fails.
> netstat shows nobody's listening on the port.

Fix for this is on the list already (Gonglei) and included in the
pending vnc pull request.

> Furthermore, the conversion to QemuOpts makes VNC visible in
> -writeconfig, but if you -readconfig it back, it doesn't quite work.
> 
> With -display vnc=:0, -writeconfig produces
> 
>     [vnc]
>       vnc = ":0"
> 
> If I append that to the config file I -readconfig, I a working VNC
> display on :0 (good), but I also get an SDL display (not good).

Will send a fix to the list in a moment.

cheers,
  Gerd