[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 00/24] qcow2: Support refcount orders != 4
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v6 00/24] qcow2: Support refcount orders != 4 |
Date: |
Tue, 17 Feb 2015 12:00:43 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 10.02.2015 um 21:28 hat Max Reitz geschrieben:
> As of version 3, the qcow2 file format supports different widths for
> refcount entries, ranging from 1 to 64 bit (only powers of two).
> Currently, qemu only supports 16 bit, which is the only width supported
> by version 2 (compat=0.10) images.
>
> This series adds support to qemu for all other valid refcount orders.
> This is mainly done by adding two function pointers into the
> BDRVQcowState structure for reading and writing refcount values
> independently of the current refcount entry width; all in-memory
> refcount arrays (mostly cached refcount blocks) now are void pointers
> and are accessed through these functions alone.
>
> Thanks to previous work of making the qemu code agnostic of e.g. the
> number of refcount entries per refcount block, the rest is fairly
> trivial. The most complex patch in this series is patch 21 which
> implements changing the refcount order through qemu-img amend.
>
> To test different refcount widths, simply invoke the qemu-iotests check
> program with -o refcount_bits=${your_desired_width}. The final test in
> this series adds some tests for operations which do not work with
> certain refcount orders and for refcount order amendment.
>
> In order for iotest 015 to succeed with refcount_bits=32 and
> refcount_bits=64, this series depends on my series
> "qcow2: Respect new_block in alloc_refcount_block()".
In order to avoid re-reviewing the same patches each time you post a new
version, I applied patches 1 to 6 now. I'll continue with reviewing the
rest later today.
Kevin
- [Qemu-devel] [PATCH v6 14/24] qcow2: Allow creation with refcount order != 4, (continued)
- [Qemu-devel] [PATCH v6 14/24] qcow2: Allow creation with refcount order != 4, Max Reitz, 2015/02/10
- [Qemu-devel] [PATCH v6 17/24] qcow2: Use error_report() in qcow2_amend_options(), Max Reitz, 2015/02/10
- [Qemu-devel] [PATCH v6 18/24] qcow2: Use abort() instead of assert(false), Max Reitz, 2015/02/10
- [Qemu-devel] [PATCH v6 23/24] qcow2: Point to amend function in check, Max Reitz, 2015/02/10
- [Qemu-devel] [PATCH v6 19/24] qcow2: Split upgrade/downgrade paths for amend, Max Reitz, 2015/02/10
- [Qemu-devel] [PATCH v6 22/24] qcow2: Invoke refcount order amendment function, Max Reitz, 2015/02/10
- [Qemu-devel] [PATCH v6 21/24] qcow2: Add function for refcount order amendment, Max Reitz, 2015/02/10
- [Qemu-devel] [PATCH v6 24/24] iotests: Add test for different refcount widths, Max Reitz, 2015/02/10
- Re: [Qemu-devel] [PATCH v6 00/24] qcow2: Support refcount orders != 4,
Kevin Wolf <=