Re: [Qemu-devel] [PATCH v2 0/3] -incoming pause

[Dr. David Alan Gilbert]

* Amit Shah (address@hidden) wrote:
> On (Wed) 11 Feb 2015 [16:46:21], Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert" <address@hidden>
> > 
> > This patchset provides a way of setting options on an incoming
> > migration before the fd/process/socket has been created.
> > 
> >    start qemu with   -incoming pause
> >    <use the monitor to set whatever you need>
> >    migrate_incoming theuri
> > 
> > v2:
> >   Create migrate_incoming/migrate-incoming rather than squashing the -u
> >   into the existing migrate command.
> 
> So the only comment I have is with the 'pause' name.
> 
> 'pause' to me means there's a time period for which a pause has to be
> done; or pausing an activity which is already in progress, both of
> which are not true for this case.

I think that pause and wait are both pretty similar; wait generally
does mean wait for something specific though.

The 'pause' button on your video player doesn't have an expectation
of how long you will pause it.

> My suggestions are 'wait' or 'hold' -- wait signifies we wait for a
> connection; the uri for which we give later; similar for hold.

Dave
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK