Re: [Qemu-devel] [PATCH v2 1/5] qga: introduce three guest memory block commmands with stubs

[Eric Blake]

On 01/21/2015 07:40 PM, zhanghailiang wrote:
> Introduce three new guest commands:
> guest-get-memory-blocks, guest-set-memory-blocks, guest-get-memory-block-size.
> 
> With these three commands, we can support online/offline guest's memory block
> (logical memory hotplug/unplug) as required from host.
> 
> Signed-off-by: zhanghailiang <address@hidden>
> ---
>  qga/commands-posix.c |  38 +++++++++++++++++
>  qga/commands-win32.c |  19 +++++++++
>  qga/qapi-schema.json | 114 
> +++++++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 171 insertions(+)
> 

> +
> +##
> +# @guest-get-memory-block-size:
> +#
> +# Get the the size (in bytes) of a memory block in guest.
> +# It is the unit of memory block online/offline operation (also called 
> Logical
> +# Memory Hotplug).
> +#
> +# Returns: memory block size in bytes.
> +#
> +# Since 2.3
> +##
> +{ 'command': 'guest-get-memory-block-size',
> +  'returns': 'int' }

Yuck.  This is not extensible.  Please consider instead providing a
dictionary-based response, so that you can add further dictionary
members in the future if you have additional pieces of information to
return.  In fact, if you do that, it might be better to name this
guest-get-memory-block-info, where size is the only info you provide
now, but where adding other parameters in the future is much easier to
predict.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature