[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 04/13] qemu-img: Suppress unhelpful extra errors
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 04/13] qemu-img: Suppress unhelpful extra errors in convert, resize |
Date: |
Tue, 17 Feb 2015 08:28:48 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 02/16/2015 07:44 AM, Markus Armbruster wrote:
> add_old_style_options() for img_convert() and img_resize() use
> qemu_opt_set(), which reports errors with qerror_report_err(). Its
> error messages aren't helpful here, the caller reports one that
> actually makes sense. Reproducer:
>
> $ qemu-img convert -B raw in.img out.img
> qemu-img: Invalid parameter 'backing_file'
> qemu-img: Backing file not supported for file format 'raw'
>
> Switch to qemu_opt_set_err() to get rid of the unwanted messages.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> qemu-img.c | 16 ++++++++++++----
> 1 file changed, 12 insertions(+), 4 deletions(-)
With pre-req patch in place,
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 00/13] QemuOpts: Convert various setters to Error, Markus Armbruster, 2015/02/16
- [Qemu-devel] [PATCH 10/13] block: Simplify setting numeric options, Markus Armbruster, 2015/02/16
- [Qemu-devel] [PATCH 04/13] qemu-img: Suppress unhelpful extra errors in convert, resize, Markus Armbruster, 2015/02/16
- [Qemu-devel] [PATCH 13/13] qtest: Use qemu_opt_set() instead of qemu_opts_parse(), Markus Armbruster, 2015/02/16
- [Qemu-devel] [PATCH 09/13] qemu-img: Suppress unhelpful extra errors in convert, amend, Markus Armbruster, 2015/02/16
- [Qemu-devel] [PATCH 01/13] QemuOpts: Convert qemu_opt_set_bool() to Error, fix its use, Markus Armbruster, 2015/02/16
- [Qemu-devel] [PATCH 11/13] qemu-sockets: Simplify setting numeric and boolean options, Markus Armbruster, 2015/02/16
- [Qemu-devel] [PATCH 02/13] QemuOpts: Convert qemu_opt_set_number() to Error, fix its use, Markus Armbruster, 2015/02/16