Re: [Qemu-devel] [PATCH v1 1/2] arm: Add the cortex-a9 CPU to the a9mpcore device

[Alistair Francis]

On Tue, Feb 10, 2015 at 4:44 PM, Peter Crosthwaite
<address@hidden> wrote:
> On Wed, Jan 21, 2015 at 5:06 PM, Alistair Francis
> <address@hidden> wrote:
>> This patch adds the Cortex-A9 ARM CPU to the A9MPCore.
>>
>> The CPU is only created if the num-cpu property is set.
>>
>> This patch relies on Stefan Hajnoczi's v3 'virtio-blk:
>> use alias properties in transport devices' patch. This is
>> used to pass the CPU properties through to the mpcore.
>>
>> This patch allows the midr and reset-cbar properties to be set
>>
>> Signed-off-by: Alistair Francis <address@hidden>
>> ---
>> Changes since RFC:
>>  - Add passthrough support for 'has_el3'
>>
>>  hw/cpu/a9mpcore.c         |   59 
>> ++++++++++++++++++++++++++++++++++++++++++++-
>>  include/hw/cpu/a9mpcore.h |    3 ++
>>  2 files changed, 61 insertions(+), 1 deletions(-)
>>
>> diff --git a/hw/cpu/a9mpcore.c b/hw/cpu/a9mpcore.c
>> index c09358c..a9c9661 100644
>> --- a/hw/cpu/a9mpcore.c
>> +++ b/hw/cpu/a9mpcore.c
>> @@ -17,10 +17,51 @@ static void a9mp_priv_set_irq(void *opaque, int irq, int 
>> level)
>>      qemu_set_irq(qdev_get_gpio_in(DEVICE(&s->gic), irq), level);
>>  }
>>
>> +static void a9mpcore_init_cpus(Object *obj, Visitor *v,
>
> Even though initing CPUs is the primary side effect, this fn is a qom
> property setter for the num_cpus property. It should be named
> a9mpcore_set_num_cpus.

Ok, I will change the name

>
>> +                               void *opaque, const char *name,
>> +                               Error **errp)
>> +{
>> +    A9MPPrivState *s = A9MPCORE_PRIV(obj);
>> +    ObjectClass *cpu_oc;
>> +    Error *err = NULL;
>> +    int i;
>> +    int64_t value;
>> +
>> +    visit_type_int(v, &value, name, &err);
>> +    if (err) {
>> +        error_propagate(errp, err);
>> +        return;
>> +    }
>> +    s->num_cpu = value;
>> +
>> +    s->cpu = g_new0(ARMCPU, s->num_cpu);
>> +    cpu_oc = cpu_class_by_name(TYPE_ARM_CPU, "cortex-a9");
>> +
>> +    for (i = 0; i < s->num_cpu; i++) {
>> +        object_initialize(&s->cpu[i], sizeof(*s->cpu),
>> +                          object_class_get_name(cpu_oc));
>> +
>> +        object_property_add_alias(obj, "midr", OBJECT(&s->cpu[i]),
>> +                                  "midr", NULL);
>> +        object_property_add_alias(obj, "reset-cbar", OBJECT(&s->cpu[i]),
>> +                                  "reset-cbar", NULL);
>> +        object_property_add_alias(obj, "has_el3", OBJECT(&s->cpu[i]),
>> +                                  "has_el3", NULL);
>> +    }
>> +}
>> +
>>  static void a9mp_priv_initfn(Object *obj)
>>  {
>>      A9MPPrivState *s = A9MPCORE_PRIV(obj);
>>
>> +    /* Set up the CPU to be initiated */
>
> Comment inaccurate. You could just delete it.

Will do

>
>> +    object_property_add(obj, "num-cpu", "int",
>> +                        NULL, a9mpcore_init_cpus,
>> +                        NULL, NULL, NULL);
>> +    /* Use this as the default */
>> +    s->cpu = NULL;
>> +    s->num_cpu = 1;
>> +
>>      memory_region_init(&s->container, obj, "a9mp-priv-container", 0x2000);
>>      sysbus_init_mmio(SYS_BUS_DEVICE(obj), &s->container);
>>
>> @@ -50,6 +91,17 @@ static void a9mp_priv_realize(DeviceState *dev, Error 
>> **errp)
>>      Error *err = NULL;
>>      int i;
>>
>> +    if (s->cpu) {
>> +        for (i = 0; i < s->num_cpu; i++) {
>> +            object_property_set_bool(OBJECT(&s->cpu[i]), true,
>> +                                     "realized", &err);
>> +            if (err) {
>> +                error_propagate(errp, err);
>> +                return;
>> +            }
>> +        }
>> +    }
>> +
>>      scudev = DEVICE(&s->scu);
>>      qdev_prop_set_uint32(scudev, "num-cpu", s->num_cpu);
>>      object_property_set_bool(OBJECT(&s->scu), true, "realized", &err);
>> @@ -75,6 +127,12 @@ static void a9mp_priv_realize(DeviceState *dev, Error 
>> **errp)
>>      /* Pass through inbound GPIO lines to the GIC */
>>      qdev_init_gpio_in(dev, a9mp_priv_set_irq, s->num_irq - 32);
>>
>> +    /* Connect the GIC to the first CPU */
>> +    if (s->cpu) {
>> +        sysbus_connect_irq(SYS_BUS_DEVICE(dev), 0,
>> +                           qdev_get_gpio_in(DEVICE(s->cpu), ARM_CPU_IRQ));
>> +    }
>> +
>
> This should loop over all CPUs and connect the GIC to each.
>
>>      gtimerdev = DEVICE(&s->gtimer);
>>      qdev_prop_set_uint32(gtimerdev, "num-cpu", s->num_cpu);
>>      object_property_set_bool(OBJECT(&s->gtimer), true, "realized", &err);
>> @@ -144,7 +202,6 @@ static void a9mp_priv_realize(DeviceState *dev, Error 
>> **errp)
>>  }
>>
>>  static Property a9mp_priv_properties[] = {
>> -    DEFINE_PROP_UINT32("num-cpu", A9MPPrivState, num_cpu, 1),
>>      /* The Cortex-A9MP may have anything from 0 to 224 external interrupt
>>       * IRQ lines (with another 32 internal). We default to 64+32, which
>>       * is the number provided by the Cortex-A9MP test chip in the
>> diff --git a/include/hw/cpu/a9mpcore.h b/include/hw/cpu/a9mpcore.h
>> index 5d67ca2..2e57116 100644
>> --- a/include/hw/cpu/a9mpcore.h
>> +++ b/include/hw/cpu/a9mpcore.h
>> @@ -15,6 +15,7 @@
>>  #include "hw/misc/a9scu.h"
>>  #include "hw/timer/arm_mptimer.h"
>>  #include "hw/timer/a9gtimer.h"
>> +#include "qapi/visitor.h"
>
> Move include to C file.

Will do

Thanks,

Alistair

>
> Regards,
> Peter
>
>>
>>  #define TYPE_A9MPCORE_PRIV "a9mpcore_priv"
>>  #define A9MPCORE_PRIV(obj) \
>> @@ -29,6 +30,8 @@ typedef struct A9MPPrivState {
>>      MemoryRegion container;
>>      uint32_t num_irq;
>>
>> +    ARMCPU *cpu;
>> +
>>      A9SCUState scu;
>>      GICState gic;
>>      A9GTimerState gtimer;
>> --
>> 1.7.1
>>
>>
>