[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v9 15/23] aio: replace stack of bottom halve
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [RFC PATCH v9 15/23] aio: replace stack of bottom halves with queue |
Date: |
Wed, 18 Feb 2015 14:06:49 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 18/02/2015 12:57, Pavel Dovgalyuk wrote:
> + QSIMPLEQ_FOREACH_SAFE(bh, &ctx->bh_queue, next, next) {
> if (bh->deleted) {
> - *bhp = bh->next;
> + QSIMPLEQ_REMOVE(&ctx->bh_queue, bh, QEMUBH, next);
QSIMPLEQ_REMOVE is very inefficient, so that this loop can become
O(n^2). You could use QTAILQ or introduce QSIMPLE_REMOVE_AFTER.
Paolo
> g_free(bh);
> - } else {
> - bhp = &bh->next;
> }
- [Qemu-devel] [RFC PATCH v9 08/23] cpu: replay instructions sequence, (continued)
- [Qemu-devel] [RFC PATCH v9 08/23] cpu: replay instructions sequence, Pavel Dovgalyuk, 2015/02/18
- [Qemu-devel] [RFC PATCH v9 09/23] replay: interrupts and exceptions, Pavel Dovgalyuk, 2015/02/18
- [Qemu-devel] [RFC PATCH v9 10/23] replay: asynchronous events infrastructure, Pavel Dovgalyuk, 2015/02/18
- [Qemu-devel] [RFC PATCH v9 11/23] replay: recording and replaying clock ticks, Pavel Dovgalyuk, 2015/02/18
- [Qemu-devel] [RFC PATCH v9 12/23] timer: replace time() with QEMU_CLOCK_HOST, Pavel Dovgalyuk, 2015/02/18
- [Qemu-devel] [RFC PATCH v9 13/23] replay: shutdown event, Pavel Dovgalyuk, 2015/02/18
- [Qemu-devel] [RFC PATCH v9 14/23] replay: checkpoints, Pavel Dovgalyuk, 2015/02/18
- [Qemu-devel] [RFC PATCH v9 15/23] aio: replace stack of bottom halves with queue, Pavel Dovgalyuk, 2015/02/18
- [Qemu-devel] [RFC PATCH v9 16/23] replay: bottom halves, Pavel Dovgalyuk, 2015/02/18
- [Qemu-devel] [RFC PATCH v9 17/23] replay: replay aio requests, Pavel Dovgalyuk, 2015/02/18
- [Qemu-devel] [RFC PATCH v9 18/23] replay: thread pool, Pavel Dovgalyuk, 2015/02/18
- [Qemu-devel] [RFC PATCH v9 19/23] typedef: add typedef for QemuOpts, Pavel Dovgalyuk, 2015/02/18
- [Qemu-devel] [RFC PATCH v9 20/23] replay: initialization and deinitialization, Pavel Dovgalyuk, 2015/02/18
- [Qemu-devel] [RFC PATCH v9 21/23] replay: replay blockers for devices, Pavel Dovgalyuk, 2015/02/18
- [Qemu-devel] [RFC PATCH v9 22/23] replay: command line options, Pavel Dovgalyuk, 2015/02/18