|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-devel] [RFC PATCH v9 06/23] replay: introduce icount event |
Date: | Wed, 18 Feb 2015 14:49:40 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 18/02/2015 12:56, Pavel Dovgalyuk wrote: > + /* nothing to skip - not all instructions used */ > + if (replay_state.instructions_count != 0 > + && replay_has_unread_data) { > + return stop_event == EVENT_INSTRUCTION; Same here, please assert that replay_data_kind == EVENT_INSTRUCTION. Assertions communicate invariants, and thus help the person reading the code. Paolo > + }
[Prev in Thread] | Current Thread | [Next in Thread] |