qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC PATCH v9 09/23] replay: interrupts and exceptions


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [RFC PATCH v9 09/23] replay: interrupts and exceptions
Date: Wed, 18 Feb 2015 15:14:52 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0


On 18/02/2015 12:56, Pavel Dovgalyuk wrote:
>      if (interrupt_request & CPU_INTERRUPT_POLL) {
>          cs->interrupt_request &= ~CPU_INTERRUPT_POLL;
>          apic_poll_irq(cpu->apic_state);
> +        /* Process one interrupt for a single call.
> +           In record/replay mode each call to this function
> +           is coupled with an event in the log */
> +        if (replay_mode != REPLAY_MODE_NONE) {
> +            return true;
> +        }

Is it okay to just return true always, even outside replay mode?  If so,
make it a separate patch.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]