Re: [Qemu-devel] [RFC PATCH 5/7] target-arm/cpu: Add apic_id property for ARMCPU

[Igor Mammedov]

On Wed, 18 Feb 2015 18:45:51 +0100
Andreas Färber <address@hidden> wrote:

> Hi,
> 
> Am 17.02.2015 um 11:10 schrieb Shannon Zhao:
> > Add apic_id property for ARMCPU. It can be used for cpu hotplug.
> > 
> > Signed-off-by: Shannon Zhao <address@hidden>
> > ---
> >  target-arm/cpu-qom.h |    1 +
> >  target-arm/cpu.c     |   77
> > ++++++++++++++++++++++++++++++++++++++++++++++++++
> > target-arm/cpu.h     |    2 + 3 files changed, 80 insertions(+), 0
> > deletions(-)
> > 
> > diff --git a/target-arm/cpu-qom.h b/target-arm/cpu-qom.h
> > index ed5a644..d4560e2 100644
> > --- a/target-arm/cpu-qom.h
> > +++ b/target-arm/cpu-qom.h
> > @@ -59,6 +59,7 @@ typedef struct ARMCPU {
> >      /*< public >*/
> >  
> >      CPUARMState env;
> > +    uint32_t apic_id;
> 
> Can you add a matching @apic_id: documentation entry above the struct?
> 
> >  
> >      /* Coprocessor information */
> >      GHashTable *cp_regs;
> > diff --git a/target-arm/cpu.c b/target-arm/cpu.c
> > index 285947f..9202b07 100644
> > --- a/target-arm/cpu.c
> > +++ b/target-arm/cpu.c
> [...]
> > @@ -343,6 +407,11 @@ static void arm_cpu_initfn(Object *obj)
> >      cpu->cp_regs = g_hash_table_new_full(g_int_hash, g_int_equal,
> >                                           g_free, g_free);
> >  
> > +    object_property_add(obj, "apic-id", "int",
> > +                    arm_cpuid_get_apic_id,
> > +                    arm_cpuid_set_apic_id, NULL, NULL, NULL);
> 
> The property is correctly called apic-id. Please update the commit
> message, which has it as apic_id (2x).
Is there such thing as apic-id on ARM?


> 
> Regards,
> Andreas
> 
> > +
> > +     cpu->apic_id = arm_cpu_apic_id_from_index(cs->cpu_index);
> >  #ifndef CONFIG_USER_ONLY
> >      /* Our inbound IRQ and FIQ lines */
> >      if (kvm_enabled()) {
> [snip]
>