[Qemu-devel] [Bug 1412098] Re: qemu crashes when ctrl-alt-u is pressed

[Ingo Krabbe]

Actually in any version this can never work, as you call

   sdl_switch(dcl,NULL);

in ui/sdl.c:552. So the dereferncing statement

   new_surface->format

must SEGFAULT.

The obvious patch is very simple, of course, as just the statement below
line 128 asks if(new_surface). So pf should be initialized after this
check:

diff --git a/ui/sdl.c b/ui/sdl.c
index 138ca73..c4fa1f6 100644
--- a/ui/sdl.c
+++ b/ui/sdl.c
@@ -125,12 +125,13 @@ static void do_sdl_resize(int width, int height, int bpp)
 static void sdl_switch(DisplayChangeListener *dcl,
                        DisplaySurface *new_surface)
 {
-    PixelFormat pf = qemu_pixelformat_from_pixman(new_surface->format);
+    PixelFormat pf;

     /* temporary hack: allows to call sdl_switch to handle scaling changes */
     if (new_surface) {
         surface = new_surface;
     }
+    pf = qemu_pixelformat_from_pixman(surface->format);

     if (!scaling_active) {
         do_sdl_resize(surface_width(surface), surface_height(surface), 0);

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1412098

Title:
  qemu crashes when ctrl-alt-u is pressed

Status in QEMU:
  New

Bug description:
  Qemu version: 2.2.0 release, compiled from source
  Host OS: Windows 7 Ultimate x64
  Guest OS: not applicable, crash occurs even without OS and occurs with all OSs
  Executable: qemu-system-i386.exe or qemu-system-i386w.exe

  To reproduce:
  Start qemu-system-i386 or qemu-system-i386w without any options. Press 
CTRL-ALT-U, which is supposed to rescale the window. Instead, qemu just crashes.

  Compilation:
  Qemu 2.2.0 release compiled from sources under MinGW on the host.
  Configure options used:
  '../qemu-2.2.0/configure' '--python=C:/Python27/python' 
'--prefix=/mingw/build/qemu-2.2.0-bin' '--target-list=i386-softmmu'

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1412098/+subscriptions