[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v13 15/17] iotests: add simple incremental backu
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v13 15/17] iotests: add simple incremental backup case |
Date: |
Fri, 20 Feb 2015 10:02:35 +0000 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Fri, Feb 13, 2015 at 05:08:56PM -0500, John Snow wrote:
> + def check_incremental(self, target=None):
> + if target is None:
> + target = self.bitmaps[-1].last_target()
> + self.assertTrue(iotests.compare_images(self.test_img, target))
> + return True
> +
> +
> + def hmp_io_writes(self, drive, patterns):
> + for pattern in patterns:
> + self.vm.hmp_qemu_io(drive, 'write -P%s %s %s' % pattern)
> + self.vm.hmp_qemu_io(drive, 'flush')
Please don't read image files while the guest is still running. Image
formats do not support concurrent readers and writers.
Three options:
1. Stop the guest before accessing self.test_img
2. Use drive-backup to make a full copy of self.test_img that can be
accessed.
3. Test specific patterns in the backup file instead of using
compare_images (qemu-io -c 'read -P 0xff 0 512' img)
pgpHpIEo48jyp.pgp
Description: PGP signature
- Re: [Qemu-devel] [PATCH v13 03/17] qmp: Add block-dirty-bitmap-add and block-dirty-bitmap-remove, (continued)
- [Qemu-devel] [PATCH v13 12/17] block: add BdrvDirtyBitmap documentation, John Snow, 2015/02/13
- [Qemu-devel] [PATCH v13 08/17] qmp: Add support of "dirty-bitmap" sync mode for drive-backup, John Snow, 2015/02/13
- [Qemu-devel] [PATCH v13 10/17] qapi: Add transaction support to block-dirty-bitmap operations, John Snow, 2015/02/13
- [Qemu-devel] [PATCH v13 11/17] qmp: Add dirty bitmap status fields in query-block, John Snow, 2015/02/13
- [Qemu-devel] [PATCH v13 15/17] iotests: add simple incremental backup case, John Snow, 2015/02/13
- [Qemu-devel] [PATCH v13 13/17] block: Ensure consistent bitmap function prototypes, John Snow, 2015/02/13
- [Qemu-devel] [PATCH v13 16/17] iotests: add transactional incremental backup test, John Snow, 2015/02/13
- [Qemu-devel] [PATCH v13 14/17] iotests: add invalid input incremental backup tests, John Snow, 2015/02/13
- [Qemu-devel] [PATCH v13 17/17] iotests: add incremental backup failure recovery test, John Snow, 2015/02/13
- Re: [Qemu-devel] [PATCH v13 00/17] block: incremental backup series, Stefan Hajnoczi, 2015/02/20