Re: [Qemu-devel] [PATCH] Makefile.target: set icon for binary file on Mac OS X

[Programmingkid]

On Feb 20, 2015, at 7:36 AM, Paolo Bonzini wrote:

> 
> 
> On 20/02/2015 13:18, Peter Maydell wrote:
>> Why not just use the sips --out option to specify a different
>> output file? That way we automatically put the current icon
>> into the executable, and don't have to update a hand-created
>> qemu.rsrc file in git if we change the icon in future (and I
>> bet if we don't have the rules for doing this in the makefile
>> then nobody will remember how to do it).
> 
> I suspect the Windows icon is not a great match for Mac OS X which likes
> to have big sizes (48x48 or 128x128).

Definitely true.

>  If you want to generate the .rsrc
> file automatically, the right source probably would be the .svg file,
> and doing the conversion in the Makefile probably isn't entirely
> feasible.  It would need extra build dependency and rounding errors
> would make it harder to achieve reproducible builds.

Plus the sips command doesn't work with svg files.