|
From: | Alexander Graf |
Subject: | Re: [Qemu-devel] [RFC PATCH v2 04/15] cpu-model/s390: Introduce S390 CPU models |
Date: | Fri, 20 Feb 2015 17:57:52 +0100 |
User-agent: | Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 20.02.15 16:49, Michael Mueller wrote: > On Fri, 20 Feb 2015 16:22:20 +0100 > Alexander Graf <address@hidden> wrote: > >>>> >>>> Just make this uint64_t fac_list[2]. That way we don't have to track any >>>> messy allocations. >>> >>> It will be something like "uint64_t >>> fac_list[S390_CPU_FAC_LIST_SIZE_UINT64]" and in total 2KB >>> not just 16 bytes but I will change it. >> >> Why? Do we actually need that many? This is a qemu internal struct. > > How do you know that 2 is a good size? Because all CPUs we have in our list only expose 128 bits? > I want to have this independent from a future machine of the z/Arch. The > kernel stores the full > facility set, KVM does and there is no good reason for QEMU not to do. If > other accelerators > decide to just implement 64 or 128 bits of facilities that's ok... So you want to support CPUs that are not part of the list? Alex
[Prev in Thread] | Current Thread | [Next in Thread] |