Re: [Qemu-devel] [PATCH] Makefile.target: set icon for binary file on Mac OS X

[Programmingkid]

On Feb 20, 2015, at 12:05 PM, Paolo Bonzini wrote:

> 
> 
> On 20/02/2015 17:54, Programmingkid wrote:
>>> I suspect the Windows icon is not a great match for Mac OS X which likes
>>> to have big sizes (48x48 or 128x128).
>> 
>> Definitely true.
>> 
>>> If you want to generate the .rsrc
>>> file automatically, the right source probably would be the .svg file,
>>> and doing the conversion in the Makefile probably isn't entirely
>>> feasible.  It would need extra build dependency and rounding errors
>>> would make it harder to achieve reproducible builds.
>> 
>> Plus the sips command doesn't work with svg files. 
> 
> Ok, so I'll apply v3 to my tree as soon as I get a Tested-by.  Please
> take a look into providing a .rsrc file with larger-sized icons (I think
> you can add more than one to a single .rsrc file?) and, when you do
> that, document in pc-bios/README how the resources were built.

When I was inspecting the icon using the genie feature of Mac OS X's dock, the 
icon looked very sharp at full size, so I didn't see a problem with it. What 
size do you have in mind?