Re: [Qemu-devel] [PATCH target-arm v1 13/15] arm: xilinx-zynq-mp-generic: Add external RAM

[Alistair Francis]

On Tue, Feb 24, 2015 at 9:04 AM, Peter Crosthwaite
<address@hidden> wrote:
> Zynq MPSoC supports external DDR RAM. Add a RAM at 0 to the model.
>
> Signed-off-by: Peter Crosthwaite <address@hidden>
> ---
>  hw/arm/xlnx-zynq-mp-generic.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/hw/arm/xlnx-zynq-mp-generic.c b/hw/arm/xlnx-zynq-mp-generic.c
> index ff69b07..7394e82 100644
> --- a/hw/arm/xlnx-zynq-mp-generic.c
> +++ b/hw/arm/xlnx-zynq-mp-generic.c
> @@ -18,9 +18,11 @@
>  #include "hw/arm/xlnx-zynq-mp.h"
>  #include "hw/boards.h"
>  #include "qemu/error-report.h"
> +#include "exec/address-spaces.h"
>
>  typedef struct XlnxZynqMPGeneric {
>      XlnxZynqMPState soc;
> +    MemoryRegion ddr_ram;
>  } XlnxZynqMPGeneric;
>
>  static void xlnx_zynq_mp_generic_init(MachineState *machine)
> @@ -36,6 +38,11 @@ static void xlnx_zynq_mp_generic_init(MachineState 
> *machine)
>          error_report("%s", error_get_pretty(err));
>          exit(1);
>      }
> +
> +    memory_region_init_ram(&s->ddr_ram, NULL, "ddr-ram", machine->ram_size,
> +                           &error_abort);

Shouldn't there be a default size if none is specified? This looks
like it will cause user
issues if they don't understand that they must specify the memory size.

At least return an error if none is specified.

Thanks,

Alistair

> +    vmstate_register_ram_global(&s->ddr_ram);
> +    memory_region_add_subregion(get_system_memory(), 0, &s->ddr_ram);
>  }
>
>  static QEMUMachine xlnx_zynq_mp_generic_machine = {
> --
> 2.3.0.1.g27a12f1
>
>