qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 6/6] rename save_block_hdr to save_page_header


From: Amit Shah
Subject: Re: [Qemu-devel] [PATCH 6/6] rename save_block_hdr to save_page_header
Date: Tue, 24 Feb 2015 18:18:41 +0530

On (Thu) 12 Feb 2015 [23:03:11], Juan Quintela wrote:
> It has always been a page header, not a block header.  Once there, the
> flag argument was only passed to make a bit or with it, just do the or
> on the caller.

I prefer not to do that -- if one looks at the function signature,
he'll only notice 'offset' there and not 'offset|flag', so it's
confusing to callers of function why the | is being done for an offset
field.

Let's keep that bit as-is?

                Amit



reply via email to

[Prev in Thread] Current Thread [Next in Thread]