[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 09/10] s390x/kvm: deliver SIGP RESTART directly if s
From: |
Jens Freimann |
Subject: |
[Qemu-devel] [PATCH 09/10] s390x/kvm: deliver SIGP RESTART directly if stopped |
Date: |
Tue, 24 Feb 2015 14:15:30 +0100 |
From: David Hildenbrand <address@hidden>
According to the PoP, a restart irq has to be delivered "without first honoring
any other pending interruptions", if a cpu is in the STOPPED state.
While it is hard to implement this case in kvm, it can easily be handled in
qemu.
Reviewed-by: Thomas Huth <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>
Signed-off-by: Jens Freimann <address@hidden>
Signed-off-by: David Hildenbrand <address@hidden>
---
target-s390x/kvm.c | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/target-s390x/kvm.c b/target-s390x/kvm.c
index ed56b3c..7f9fd02 100644
--- a/target-s390x/kvm.c
+++ b/target-s390x/kvm.c
@@ -1241,8 +1241,17 @@ static void sigp_restart(void *arg)
.type = KVM_S390_RESTART,
};
- kvm_s390_vcpu_interrupt(si->cpu, &irq);
- s390_cpu_set_state(CPU_STATE_OPERATING, si->cpu);
+ switch (s390_cpu_get_state(si->cpu)) {
+ case CPU_STATE_STOPPED:
+ /* the restart irq has to be delivered prior to any other pending irq
*/
+ cpu_synchronize_state(CPU(si->cpu));
+ do_restart_interrupt(&si->cpu->env);
+ s390_cpu_set_state(CPU_STATE_OPERATING, si->cpu);
+ break;
+ case CPU_STATE_OPERATING:
+ kvm_s390_vcpu_interrupt(si->cpu, &irq);
+ break;
+ }
si->cc = SIGP_CC_ORDER_CODE_ACCEPTED;
}
--
2.1.4
- [Qemu-devel] [PATCH 00/10] s390x: move sigp handling to user space, Jens Freimann, 2015/02/24
- [Qemu-devel] [PATCH 05/10] s390x/kvm: trace all SIGP orders, Jens Freimann, 2015/02/24
- [Qemu-devel] [PATCH 10/10] s390x/kvm: enable the new SIGP handling in user space, Jens Freimann, 2015/02/24
- [Qemu-devel] [PATCH 03/10] s390x/kvm: pass the SIGP instruction parameter to the SIGP handler, Jens Freimann, 2015/02/24
- [Qemu-devel] [PATCH 04/10] s390x/kvm: helper to set the SIGP status in SigpInfo, Jens Freimann, 2015/02/24
- [Qemu-devel] [PATCH 01/10] s390x: introduce defines for SIGP condition codes, Jens Freimann, 2015/02/24
- [Qemu-devel] [PATCH 09/10] s390x/kvm: deliver SIGP RESTART directly if stopped,
Jens Freimann <=
- [Qemu-devel] [PATCH 06/10] s390x/kvm: implement handling of new SIGP orders, Jens Freimann, 2015/02/24
- [Qemu-devel] [PATCH 07/10] s390x/kvm: SIGP START is only applicable when STOPPED, Jens Freimann, 2015/02/24
- [Qemu-devel] [PATCH 08/10] s390x: add function to deliver restart irqs, Jens Freimann, 2015/02/24
- [Qemu-devel] [PATCH 02/10] s390x/kvm: more details for SIGP handler with one destination vcpu, Jens Freimann, 2015/02/24