[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 08/10] serial: serial_hds_isa_init() shouldn't fail
From: |
Andreas Färber |
Subject: |
[Qemu-devel] [PULL 08/10] serial: serial_hds_isa_init() shouldn't fail |
Date: |
Tue, 24 Feb 2015 14:58:28 +0100 |
From: Markus Armbruster <address@hidden>
It shouldn't fail, and no caller checks for failure. Make failure
fatal.
Maintainers of affected machines cc'ed.
Cc: Richard Henderson <address@hidden>
Cc: Anthony Liguori <address@hidden>
Cc: "Michael S. Tsirkin" <address@hidden>
Cc: Aurelien Jarno <address@hidden>
Cc: Leon Alrae <address@hidden>
Cc: Blue Swirl <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>
---
hw/char/serial-isa.c | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/hw/char/serial-isa.c b/hw/char/serial-isa.c
index 059ceb8..f3db024 100644
--- a/hw/char/serial-isa.c
+++ b/hw/char/serial-isa.c
@@ -119,22 +119,16 @@ static void serial_register_types(void)
type_init(serial_register_types)
-static bool serial_isa_init(ISABus *bus, int index, CharDriverState *chr)
+static void serial_isa_init(ISABus *bus, int index, CharDriverState *chr)
{
DeviceState *dev;
ISADevice *isadev;
- isadev = isa_try_create(bus, TYPE_ISA_SERIAL);
- if (!isadev) {
- return false;
- }
+ isadev = isa_create(bus, TYPE_ISA_SERIAL);
dev = DEVICE(isadev);
qdev_prop_set_uint32(dev, "index", index);
qdev_prop_set_chr(dev, "chardev", chr);
- if (qdev_init(dev) < 0) {
- return false;
- }
- return true;
+ qdev_init_nofail(dev);
}
void serial_hds_isa_init(ISABus *bus, int n)
--
2.1.4
- [Qemu-devel] [PULL 00/10] QOM devices patch queue 2015-02-24, Andreas Färber, 2015/02/24
- [Qemu-devel] [PULL 08/10] serial: serial_hds_isa_init() shouldn't fail,
Andreas Färber <=
- [Qemu-devel] [PULL 07/10] serial: Factor out common serial_hds_isa_init(), Andreas Färber, 2015/02/24
- [Qemu-devel] [PULL 01/10] qdev: Avoid type assertion in qdev_build_hotpluggable_device_list(), Andreas Färber, 2015/02/24
- [Qemu-devel] [PULL 02/10] qom: Fix typo, 'my_class_init' -> 'derived_class_init', Andreas Färber, 2015/02/24
- [Qemu-devel] [PULL 05/10] leon3: Replace unchecked qdev_init() by qdev_init_nofail(), Andreas Färber, 2015/02/24
- [Qemu-devel] [PULL 09/10] parallel: Factor out common parallel_hds_isa_init(), Andreas Färber, 2015/02/24
- [Qemu-devel] [PULL 06/10] etsec: Replace qdev_init() by qdev_init_nofail(), Andreas Färber, 2015/02/24
- [Qemu-devel] [PULL 04/10] ide/isa: Replace unchecked qdev_init() by qdev_init_nofail(), Andreas Färber, 2015/02/24
- [Qemu-devel] [PULL 03/10] qdev: Improve qdev_init_nofail()'s error reporting, Andreas Färber, 2015/02/24
- [Qemu-devel] [PULL 10/10] parallel: parallel_hds_isa_init() shouldn't fail, Andreas Färber, 2015/02/24
- Re: [Qemu-devel] [PULL 00/10] QOM devices patch queue 2015-02-24, Mark Cave-Ayland, 2015/02/24