[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] block: Add QMP support for streaming to an
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] block: Add QMP support for streaming to an intermediate layer |
Date: |
Tue, 24 Feb 2015 15:08:52 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Kevin Wolf <address@hidden> writes:
> Am 23.02.2015 um 13:23 hat Alberto Garcia geschrieben:
>> On Fri, Feb 20, 2015 at 03:38:04PM -0700, Eric Blake wrote:
>>
>> > > + if (has_top) {
>> > > + top_bs = bdrv_find_backing_image(bs, top);
>> > > + if (top_bs == NULL) {
>> > > + error_set(errp, QERR_TOP_NOT_FOUND, top);
>> > > + goto out;
>> > > + }
>> >
>> > If I understand correctly, bdrv_find_backing_image has problems for
>> > backing nodes that don't have a file name. Given our shift towards
>> > node names, I think we really want to target node names rather than
>> > file names when specifying which node we will use as the top bound
>> > receiving the stream operations.
>>
>> Sure I can change that, but note that the 'base' parameter also
>> receives a file name and uses bdrv_find_backing_image, so I guess it
>> makes sense to change it in both sides.
>
> Yes, using the file name for identifying nodes was a mistake. We're
> going to replace all occurrences of it sooner or later. Not sure if
> someone is actively working on this currently - Markus?
Not currently, sorry. I agree it needs doing.
> For your patch series, I think it's good enough to use node names for
> the new parameter. Converting old parameters is a separate issue.
Makes sense.
Re: [Qemu-devel] [PATCH 0/3] Support streaming to an intermediate layer, Eric Blake, 2015/02/20