Re: [Qemu-devel] [PATCH 9/9] throttle: add name of ThrottleGroup to BlockDeviceInfo

[Eric Blake]

On 02/13/2015 09:06 AM, Alberto Garcia wrote:
> Replace also throttle_group_compare() with throttle_group_get_name()
> 
> Signed-off-by: Alberto Garcia <address@hidden>
> ---
>  block.c                         |  2 +-
>  block/qapi.c                    |  5 +++++
>  block/throttle-groups.c         | 14 ++++----------
>  hmp.c                           |  6 ++++--
>  include/block/throttle-groups.h |  2 +-
>  qapi/block-core.json            |  4 +++-
>  6 files changed, 18 insertions(+), 15 deletions(-)
> 

> +++ b/qapi/block-core.json
> @@ -255,6 +255,8 @@
>  #
>  # @iops_size: #optional an I/O size in bytes (Since 1.7)
>  #
> +# @group: #optional throttle group name (Since 2.3)
> +#
>  # @cache: the cache mode used for the block device (since: 2.3)

Ugh - now I'm getting confused by context.  Looks like 7/9 touched
block_set_io_throttle, and 9/9 touches BlockDeviceInfo.

>  #
>  # @write_threshold: configured write threshold for the device.
> @@ -274,7 +276,7 @@
>              '*bps_max': 'int', '*bps_rd_max': 'int',
>              '*bps_wr_max': 'int', '*iops_max': 'int',
>              '*iops_rd_max': 'int', '*iops_wr_max': 'int',
> -            '*iops_size': 'int', 'cache': 'BlockdevCacheInfo',
> +            '*iops_size': 'int', '*group': 'str', 'cache': 
> 'BlockdevCacheInfo',
>              'write_threshold': 'int' } }
>  

Questions - with this series in place, is it ever possible to have
throttling parameters without a throttle group name?  Do we
auto-generate a group name (perhaps based on the node name) for any
throttling parameters set without reference to a group name?  When using
block_set_io_throttle, is it legal to pass parameters (like bps_max) and
a group name at the same time, and if so, what happens if there is
already a throttle group by that name?

Is there a command that can return the list of all throttle group names?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature