Re: [Qemu-devel] [PATCH 1/2] Makefile: don't silence mak file test with V=1

[Fam Zheng]

On Thu, 02/19 08:48, Michael S. Tsirkin wrote:
> V=1 should show what's going on, it's not nice
> to silence things unconditionally.
> 
> Signed-off-by: Michael S. Tsirkin <address@hidden>
> ---
>  Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 6817c6f..84ca8be 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -110,7 +110,7 @@ endif
>  
>  %/config-devices.mak: default-configs/%.mak
>       $(call quiet-command,$(SHELL) $(SRC_PATH)/scripts/make_device_config.sh 
> $@ $<, "  GEN   $@")
> -     @if test -f $@; then \
> +     $(call quiet-command, if test -f $@; then \
>         if cmp -s address@hidden $@; then \
>           mv address@hidden $@; \
>           cp -p $@ address@hidden; \
> @@ -126,7 +126,7 @@ endif
>        else \
>         mv address@hidden $@; \
>         cp -p $@ address@hidden; \
> -      fi
> +      fi, "  TEST $@");

Probably "  GEN   $@" is better, otherwise:

Reviewed-by: Fam Zheng <address@hidden>

>  
>  defconfig:
>       rm -f config-all-devices.mak $(SUBDIR_DEVICES_MAK)
> -- 
> MST
>