qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/8] machine: query machine properties rather th


From: Marcel Apfelbaum
Subject: Re: [Qemu-devel] [PATCH 0/8] machine: query machine properties rather than qemu opts
Date: Wed, 25 Feb 2015 13:55:07 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0

On 02/04/2015 05:43 PM, Marcel Apfelbaum wrote:
Commit e79d5a6 ("machine: remove qemu_machine_opts global list") removed option
descriptions from the -machine QemuOptsList to avoid repeating MachineState's 
QOM properties.

This results in a Qemu crash if a non string option is queried using qemu opts.
Fix this by querying machine properties through designated wrappers.

I hope I didn't miss anything.
Comments are appreciated as always.
Ping

Hi, who can take this series?
It solves some command line bugs and people were pretty annoyed about it.

Thanks,
Marcel


Thanks,
Marcel

Marcel Apfelbaum (8):
   machine: query iommu machine property rather than qemu opts
   hw/machine: kernel-irqchip property support for allowed/required
   machine: query kernel-irqchip machine property rather than qemu opts
   kvm: add machine state to kvm_arch_init
   machine: query kvm-shadow-mem machine property rather than qemu opts
   machine: query phandle-start machine property rather than qemu opts
   machine: query dump-guest-core machine property rather than qemu opts
   machine: query mem-merge machine property rather than qemu opts

  device_tree.c        |  5 ++---
  exec.c               |  6 +++---
  hw/core/machine.c    | 52 +++++++++++++++++++++++++++++++++++++++++++---------
  hw/pci-host/q35.c    |  2 +-
  hw/ppc/e500.c        | 16 +++++-----------
  hw/ppc/spapr.c       | 16 ++++++----------
  include/hw/boards.h  | 10 +++++++++-
  include/sysemu/kvm.h |  2 +-
  kvm-all.c            |  8 ++++----
  target-arm/kvm.c     |  2 +-
  target-i386/kvm.c    |  5 ++---
  target-mips/kvm.c    |  2 +-
  target-ppc/kvm.c     |  2 +-
  target-s390x/kvm.c   |  2 +-
  14 files changed, 80 insertions(+), 50 deletions(-)





reply via email to

[Prev in Thread] Current Thread [Next in Thread]