Re: [Qemu-devel] [PATCH 7/8] qtest/ahci: add qcow2 support to ahci-test

[Stefan Hajnoczi]

On Wed, Feb 25, 2015 at 05:40:00PM -0500, John Snow wrote:
> 
> 
> On 02/25/2015 10:27 AM, Stefan Hajnoczi wrote:
> >On Thu, Feb 19, 2015 at 05:30:02PM -0500, John Snow wrote:
> >>diff --git a/tests/libqos/libqos.c b/tests/libqos/libqos.c
> >>index bc8beb2..3577401 100644
> >>--- a/tests/libqos/libqos.c
> >>+++ b/tests/libqos/libqos.c
> >>@@ -61,3 +61,33 @@ void qtest_shutdown(QOSState *qs)
> >>      qtest_quit(qs->qts);
> >>      g_free(qs);
> >>  }
> >>+
> >>+int mkqcow2(const char *file, unsigned size_mb)
> >>+{
> >>+    pid_t pid;
> >>+    int rc;
> >>+    char buff[32];
> >>+
> >>+    snprintf(buff, 32, "%uM", size_mb);
> >>+
> >>+    pid = fork();
> >>+    switch (pid) {
> >>+    case -1:
> >>+        perror("fork failed");
> >>+        return -1;
> >>+    case 0:
> >>+        close(fileno(stdout));
> >>+        rc = open("/dev/null", O_WRONLY);
> >>+        g_assert_cmpint(rc, ==, fileno(stdout));
> >>+        execl("./qemu-img", "qemu-img", "create", "-f", "qcow2",
> >>+              file, buff, NULL);
> >
> >Where is the current working directory set?
> >
> 
> Nowhere in-program. We assume you are running this via `make check` which
> further assumes that qemu-img is in your build tree. We actually never set
> an explicit path for where the QEMU binary is either: it's set to e.g.:
> 
> QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64
> and then executed via execlp("exec QTEST_QEMU_BINARY", ...)
> 
> This patch pulls a similar shortcut.

Okay, if the QEMU binary itself is invoked that way then this is fine.

Stefan

pgpdK1uNrdOgK.pgp
Description: PGP signature