Re: [Qemu-devel] [PULL 04/11] target-i386: Rename cpu_x86_init() to cpu_x86_init_user()

[Eduardo Habkost]

On Wed, Feb 25, 2015 at 11:06:55PM +0100, Andreas Färber wrote:
> Am 25.02.2015 um 20:58 schrieb Eduardo Habkost:
> > The function is used only for CONFIG_USER, so make its purpose clear.
> > 
> > Reviewed-by: Paolo Bonzini <address@hidden>
> > Signed-off-by: Eduardo Habkost <address@hidden>
> > ---
> >  target-i386/cpu.c | 2 +-
> >  target-i386/cpu.h | 4 ++--
> >  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> Please don't. I happily got all architectures aligned that it's at least
> cpu_something_init, and it only happens to be user-only for x86. It is
> rather the legacy function that was used in both system and user.

If that's a legacy function, what are the steps you plan to follow to
eliminate it? I would be glad to help eliminating legacy code.

Initialization of CPUs in *-user and *-softmmu is different in i386, so
we are going to have different code for both. How do you think I should
name the *-user-specific CPU init function in target-i386, then?

-- 
Eduardo