[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] disas/microblaze: Fix warnings caused by missin
From: |
Michael Tokarev |
Subject: |
Re: [Qemu-devel] [PATCH] disas/microblaze: Fix warnings caused by missing 'static' attribute |
Date: |
Mon, 02 Mar 2015 14:04:14 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0 |
01.03.2015 16:18, Stefan Weil wrote:
> Warnings from the Sparse static analysis tool:
[...]
> @@ -738,7 +737,9 @@ get_field_special (long instr, struct op_code_struct * op)
> default :
> {
> if ( ((((instr & IMM_MASK) >> IMM_LOW) ^ op->immval_mask) & 0xE000)
> == REG_PVR_MASK) {
> - sprintf(tmpstr, "%spvr%d", register_prefix, (unsigned short)(((instr &
> IMM_MASK) >> IMM_LOW) ^ op->immval_mask) ^ REG_PVR_MASK);
> + sprintf(tmpstr, "%s%u", pvr_register_prefix,
> + (unsigned short)(((instr & IMM_MASK) >> IMM_LOW) ^
> + op->immval_mask) ^ REG_PVR_MASK);
Is this word wrapping intentionally put into this patch or
was it supposed to be a separate patch?
Thanks,
/mjt