Re: [Qemu-devel] [PATCH] trace: add DTrace reserved words for .d files

[Stefan Hajnoczi]

On Thu, Aug 14, 2014 at 11:39:23AM +0100, Stefan Hajnoczi wrote:
> DTrace on Mac OS X fails due to trace events using 'self' as an argument
> name:
> 
>   GEN   trace/generated-tracers-dtrace.h
> dtrace: failed to compile script trace/generated-tracers-dtrace.dtrace: line 
> 1330: syntax error, unexpected DT_KEY_SELF, expecting ) near "self"
> make: *** [trace/generated-tracers-dtrace.h] Error 1
> 
> Filter argument names according to the list of DTrace .d file reserved
> keywords.
> 
> Note that DTrace on Mac and Linux still do not work after this patch.
> There are additional build issues remaining.
> 
> Reported-by: Henk Poley <address@hidden>
> Tested-by: Henk Poley <address@hidden>
> Cc: Lluís Vilanova <address@hidden>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
>  scripts/tracetool/format/d.py | 26 +++++++++++++++++++-------
>  1 file changed, 19 insertions(+), 7 deletions(-)

Thanks, applied to my tracing tree:
https://github.com/stefanha/qemu/commits/tracing

Stefan

pgpl2o67XdLa_.pgp
Description: PGP signature