Re: [Qemu-devel] [PATCH] qxl: drop update_displaychangelistener call for secondary qxl devices

[Brad Campbell]

On 03/03/15 00:09, Gerd Hoffmann wrote:
> Commit 3dcadce5076d4b42fa395c39662d65e050b77784 added three
> update_displaychangelistener call sites:
>
> Two for primary qxl cards, when entering/leaving vga mode, which are
> correct.
>
> One for secondary qxl cards, which is wrong because we don't register
> a displaychangelistener in the first place for secondary cards.
>
> Remove it.
>
> Reported-by: Brad Campbell <address@hidden>
> Signed-off-by: Gerd Hoffmann <address@hidden>
Tested-by: Brad Campbell <address@hidden>

> ---
>   hw/display/qxl.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/hw/display/qxl.c b/hw/display/qxl.c
> index 94ff52a..762f75d 100644
> --- a/hw/display/qxl.c
> +++ b/hw/display/qxl.c
> @@ -1147,7 +1147,6 @@ static void qxl_soft_reset(PCIQXLDevice *d)
>           qxl_enter_vga_mode(d);
>       } else {
>           d->mode = QXL_MODE_UNDEFINED;
> -        update_displaychangelistener(&d->ssd.dcl, GUI_REFRESH_INTERVAL_IDLE);
>       }
>   }

Many thanks for the rapid response Gerd.

Regards,
Brad