[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] migration: Convert 'status' of MigrationInfo
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] migration: Convert 'status' of MigrationInfo to use an enum type |
|
Date: |
Tue, 03 Mar 2015 10:21:51 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 03/03/2015 12:15 AM, zhanghailiang wrote:
>>>
>>> Yes, this is the reason ..., agreed, i don't like the abbreviate,
>>> But there is already a 'MigrationState' type defined:
>>>
>>
>>>
>>> So, what about MigrationStatus ? ;)
>>
>> That would be fine with me.
>>
>
> Bad news, this name has also been used :(
>
> In hmp.c:
>
> typedef struct MigrationStatus
You know, you could always rename the internal-only conflict into
something else so that the publicly exported typename is nice. Yeah,
that makes the series longer, but it should be all mechanical
conversions, right? I'm not going to be too picky about what color we
paint this bikeshed, though.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature