[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4 2/5] target-i386: Remove unused APIC ID default c
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [PATCH v4 2/5] target-i386: Remove unused APIC ID default code |
Date: |
Tue, 3 Mar 2015 23:13:41 -0300 |
The existing apic_id = cpu_index code has no visible effect: the PC code
already initializes the APIC ID according to the topology on
pc_new_cpu(), and linux-user memcpy()s the CPU state (including
cpuid_apic_id) on cpu_copy().
Remove the dead code and simply let APIC ID to to be 0 by default. This
doesn't change behavior of PC because apic-id is already explicitly set,
and doesn't affect linux-user because APIC ID was already always 0.
Signed-off-by: Eduardo Habkost <address@hidden>
---
target-i386/cpu.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 8fc5727..05cac57 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -2923,7 +2923,6 @@ static void x86_cpu_initfn(Object *obj)
NULL, NULL, (void *)cpu->filtered_features, NULL);
cpu->hyperv_spinlock_attempts = HYPERV_SPINLOCK_NEVER_RETRY;
- env->cpuid_apic_id = x86_cpu_apic_id_from_index(cs->cpu_index);
x86_cpu_load_def(cpu, xcc->cpu_def, &error_abort);
--
2.1.0
[Qemu-devel] [PATCH v4 4/5] target-i386: Move APIC ID compatibility code to pc.c, Eduardo Habkost, 2015/03/03