qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [Qemu-ppc] [PATCH] Introduce machine specific default m


From: Nikunj A Dadhania
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH] Introduce machine specific default memory size
Date: Wed, 04 Mar 2015 16:41:46 +0530
User-agent: Notmuch/0.17+27~gae47d61 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-redhat-linux-gnu)

Nikunj A Dadhania <address@hidden> writes:

> Markus Armbruster <address@hidden> writes:
>
>> Nikunj A Dadhania <address@hidden> writes:
>>
>>> diff --git a/vl.c b/vl.c
>>> index eb89d62..dd56754 100644
>>> --- a/vl.c
>>> +++ b/vl.c
>>> @@ -4053,6 +4053,18 @@ int main(int argc, char **argv, char **envp)
>>>          exit(1);
>>>      }
>>>  
>>> +    if (machine_class->default_ram_size && ram_size < 
>>> machine_class->default_ram_size) {
>>> +        fprintf(stderr, "qemu: %s guest ram size defaulting to %ld MB\n",
>>> +                machine_class->name,
>>> +                machine_class->default_ram_size / (1024 * 1024));
>>
>> If the user explicitly asks for something, we either provide it
>> silently, or we error out.  This does neither.  Why?
>
> In case the user has provided memory not enough to boot the machine, I
> could error out. My idea was to have a sane default which is provided by
> the machine.
>
> Initially, I had just "ram_size == default_ram_size", but then it was
> allowing "-m 128M" to go through. And the VM would not boot. 
>
> This can as well be converted to an error report and fail here to boot
> the VM.
>
>>
>>> +        ram_size = machine_class->default_ram_size;
>>> +
>>> +        /* if maxram size is not provided in options use machine default */
>>> +        if (maxram_size == default_ram_size) {
>>> +            maxram_size = machine_class->default_ram_size;
>>> +        }
>>> +    }
>>> +
>>>      /* store value for the future use */
>>>      qemu_opt_set_number(qemu_find_opts_singleton("memory"), "size", 
>>> ram_size);
>>
>> Does not apply to master, please name your prerequisite patches or
>> rebase.
>
>
> Rebased patch:
>
>
>     Introduce machine specific default memory size
>     
>     Qemu default memory of 128MB is not enough to boot sPAPR
>     guest. Introduce a member in the machine class to override the default
>     memory size enforced by qemu.
>     
>     Signed-off-by: Nikunj A Dadhania <address@hidden>

Ignore this, will be sending a v2




reply via email to

[Prev in Thread] Current Thread [Next in Thread]