[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 6/6] target-arm: cpu.h document why env->spsr
|
From: |
Alex Bennée |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 6/6] target-arm: cpu.h document why env->spsr exists |
|
Date: |
Wed, 04 Mar 2015 16:27:29 +0000 |
Peter Maydell <address@hidden> writes:
> On 4 March 2015 at 23:35, Alex Bennée <address@hidden> wrote:
>> I was getting very confused about the duplication of state. Perhaps we
>> should just get rid of env->spsr and use helpers that understand the
>> banking?
>
> Doesn't seem worth changing the current working code to something
> else that's strictly less efficient... spsr is by no means the
> only banked-by-mode register, and it works just like all the others.
Fair enough. I just wanted to make it clear it was a cached value for
the benefit of TCG.
>
> -- PMM
--
Alex Bennée
- Re: [Qemu-devel] [PATCH v2 3/6] hw/char: pl011 don't keep setting the IRQ if nothing changed, (continued)
[Qemu-devel] [PATCH v2 1/6] target-arm: kvm: save/restore mp state, Alex Bennée, 2015/03/04
[Qemu-devel] [PATCH v2 6/6] target-arm: cpu.h document why env->spsr exists, Alex Bennée, 2015/03/04