[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 6/6] target-i386: Call cpu_exec_init() on realiz
|
From: |
Eduardo Habkost |
|
Subject: |
Re: [Qemu-devel] [PATCH 6/6] target-i386: Call cpu_exec_init() on realize |
|
Date: |
Thu, 5 Mar 2015 13:48:35 -0300 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Thu, Mar 05, 2015 at 05:44:58PM +0100, Andreas Färber wrote:
> Am 05.03.2015 um 17:42 schrieb Igor Mammedov:
[...]
> >> @@ -2840,7 +2842,6 @@ static void x86_cpu_initfn(Object *obj)
> >> CPUX86State *env = &cpu->env;
> >>
> >> cs->env_ptr = env;
> >> - cpu_exec_init(env);
> > looks wrong, later in this function we do
> > env->cpuid_apic_id = x86_cpu_apic_id_from_index(cs->cpu_index);
> > and with this patch will always yield 0
>
> Being tackled in Eduardo's APIC series. ;)
Which is already queued at the x86 tree mentioned in the cover letter,
BTW:
https://github.com/ehabkost/qemu.git x86
--
Eduardo