Re: [Qemu-devel] [RFC 0/1] Rolling stats on colo

[zhanghailiang]

On 2015/3/5 21:31, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <address@hidden>

Hi Dave,

> Hi,
>    I'm getting COLO running on a couple of our machines here
> and wanted to see what was actually going on, so I merged
> in my recent rolling-stats code:
>
> http://lists.gnu.org/archive/html/qemu-devel/2015-03/msg00648.html
>
> with the following patch, and now I get on the primary side,
> info migrate shows me:
>
> capabilities: xbzrle: off rdma-pin-all: off auto-converge: off zero-blocks: off 
> colo: on
> Migration status: colo
> total time: 0 milliseconds
> colo checkpoint (ms): Min/Max: 0, 10000 Mean: -1.1415868e-13 (Weighted: 
> 4.3136025e-158) Count: 4020 Values: address@hidden, address@hidden, 
> address@hidden, address@hidden, address@hidden, address@hidden, address@hidden, 
> address@hidden, address@hidden, address@hidden
> colo paused time (ms): Min/Max: 55, 2789 Mean: 63.9 (Weighted: 76.243584) 
> Count: 4019 Values: address@hidden, address@hidden, address@hidden, 
> address@hidden, address@hidden, address@hidden, address@hidden, address@hidden, 
> address@hidden, address@hidden
> colo checkpoint size: Min/Max: 18351, 2.1731606e+08 Mean: 150096.4 (Weighted: 
> 127195.56) Count: 4020 Values: address@hidden, address@hidden, address@hidden, 
> address@hidden, address@hidden, address@hidden, address@hidden, address@hidden, 
> address@hidden, address@hidden
>
> which suggests I've got a problem with the packet comparison; but that's
> a separate issue I'll look at.

There is an obvious mistake we have made in proxy, the macro 
'IPS_UNTRACKED_BIT' in colo-patch-for-kernel.patch should be 14,
so please fix it before do the follow test. Sorry for this low-grade mistake, 
we should do full test before issue it. ;)

To be honest, the proxy part in github is not integrated, we have cut it just 
for easy review and understand, so there may be some mistakes.

Thanks,
zhanghailiang


> Dave
>
> Dr. David Alan Gilbert (1):
>    COLO: Add primary side rolling statistics
>
>   hmp.c                         | 12 ++++++++++++
>   include/migration/migration.h |  3 +++
>   migration/colo.c              | 15 +++++++++++++++
>   migration/migration.c         | 30 ++++++++++++++++++++++++++++++
>   qapi-schema.json              | 11 ++++++++++-
>   5 files changed, 70 insertions(+), 1 deletion(-)