qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH V3 10/14] virtio: introduce virtio_queue_get_ind


From: Jason Wang
Subject: Re: [Qemu-devel] [PATCH V3 10/14] virtio: introduce virtio_queue_get_index()
Date: Fri, 06 Mar 2015 10:49:04 +0800



On Thu, Mar 5, 2015 at 2:12 PM, Fam Zheng <address@hidden> wrote:
On Thu, 03/05 13:48, Jason Wang wrote:
 This patch introduces a helper that can get the queue index of a
 VirtQueue. This is useful when traversing the list of VirtQueues.
Cc: Anthony Liguori <address@hidden>
 Cc: Michael S. Tsirkin <address@hidden>
 Signed-off-by: Jason Wang <address@hidden>
 ---
  hw/virtio/virtio.c         | 5 +++++
  include/hw/virtio/virtio.h | 1 +
  2 files changed, 6 insertions(+)
diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
 index 5e6b879..bd32518 100644
 --- a/hw/virtio/virtio.c
 +++ b/hw/virtio/virtio.c
@@ -725,6 +725,11 @@ hwaddr virtio_queue_get_addr(VirtIODevice *vdev, int n)
      return vdev->vq[n].pa;
  }
+int virtio_queue_get_index(VirtIODevice *vdev, VirtQueue *vq)
 +{
 +    return vq - vdev->vq;

Probably assert the return value is within [0, virtio_get_queue_max(vdev))?

Fam

Not sure this is necessary. If we add one such here, we probably needs to add more elsewhere.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]