Re: [Qemu-devel] [PATCH] target-tricore: Fix two helper functions (clang warnings)

[Peter Maydell]

On 7 March 2015 at 18:33, Stefan Weil <address@hidden> wrote:
> diff --git a/target-tricore/op_helper.c b/target-tricore/op_helper.c
> index ed26b30..52ad80b 100644
> --- a/target-tricore/op_helper.c
> +++ b/target-tricore/op_helper.c
> @@ -1244,9 +1244,9 @@ uint64_t helper_dvinit_b_13(CPUTriCoreState *env, 
> uint32_t r1, uint32_t r2)
>          quotient_sign = 1;
>      }
>
> -    abs_sig_dividend = abs(r1) >> 7;
> -    abs_base_dividend = abs(r1) & 0x7f;
> -    abs_divisor = abs(r1);
> +    abs_sig_dividend = abs((int32_t)r1) >> 7;
> +    abs_base_dividend = abs((int32_t)r1) & 0x7f;
> +    abs_divisor = abs((int32_t)r1);

Also, surely some of these should be using r2, not r1?
At the moment we seem to use r1 for both dividend and
divisor, which does not look right at all...

-- PMM