Re: [Qemu-devel] [PATCH 1/3] 9pfs-proxy: simplify error handling

[Aneesh Kumar K.V]

Michael Tokarev <address@hidden> writes:

> All filesystem methods that call common v9fs_request() function
> also convert return value to errno.  Move this conversion to the
> common function and remove redundand error handling in methods.
>
> I didn't remove local `retval' variable in simple functions to
> keep the code consistent.
>
> Also, proxy_truncate() seem to prefer zero successful return
> instead of returning whatever the helper returned, maybe this
> should be changed.
>
> This also removes (harmless) double call to v9fs_string_free()
> in proxy_mkdir(), and renames local variables in some functions
> for consistency.

Can you keep the variable rename as a separate patch. That will make it
easier to review. Let me know if you want me to do that for you.

-aneesh