qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/2] libxl: introduce libxl__is_igd_vga_passthru


From: Wei Liu
Subject: Re: [Qemu-devel] [PATCH 1/2] libxl: introduce libxl__is_igd_vga_passthru
Date: Mon, 9 Mar 2015 10:12:11 +0000
User-agent: Mutt/1.5.23 (2014-03-12)

On Mon, Mar 09, 2015 at 02:27:46PM +0800, Chen, Tiejun wrote:
[...]
> >>+
> >>+    FILE *f = fopen(pci_device_vendor_path, "r");
> >>+    if (!f) {
> >>+        LOGE(ERROR,
> >>+             "pci device "PCI_BDF" does not have vendor attribute",
> >>+             pcidev->domain, pcidev->bus, pcidev->dev, pcidev->func);
> >>+        return 0xffff;
> >>+    }
> >>+    read_items = fscanf(f, "0x%lx\n", &pci_device_vendor);
> 
> we have to refactor this as well,
> 
> read_items = fscanf(f, "0x%hx\n", &pci_device_vendor);
> 
> Right?
> 

Sure. Just eliminate any warnings / errors.

Wei.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]